tell dconf-edit about relocatable schemas #1355
Conversation
|
here result of applying relocatable schema |
dnk
force-pushed
the
dconf-relocatable-schemas
branch
3 times, most recently
from
ef7481b to
6dc1bb4
Compare
|
@dnk I don't quite understand the meaning of the commit message. Can you supplement the information and compress the submission |
|
@zhuyaliang these changes are evolution of mate-desktop/mate-desktop#300 dconf-editor have ca.desrt.dconf-editor.Settings:relocatable-schemas-user-paths to specify users' relocatable schemas
this pull request update ca.desrt.dconf-editor.Settings:relocatable-schemas-user-paths to allow dconf-editor to use information about users' relocatable schema and to show it properly |
|
@dnk Thank you for your explanation. I can test it now |
remove duplicated schemas for currect path remove incorrect schemas for current path
add "transfer full" annotation to make this method available throught introspection
dnk
force-pushed
the
dconf-relocatable-schemas
branch
from
a7927f8 to
1e26df3
Compare
There was a problem hiding this comment.
Builds and runs without any obvious problems, but I'm not the best reviewer for this one.
This cannot be tested for function with older versions of dconf-editor as they do not support relocatable schemas. I normally keep dconf-editor locked to version 3.18 as I have difficulty with the UI on newer versions. Testing with 3.36 this appeared to work, the name of the schema came up, and as a simple test I was able to lock the clock applet to the panel from it but wasn't able to find the custom font prefs from #1358
which I had build with this.
Assuming that's a problem with the other PR or just an inability of myself to navigate the newer dconf-editor UI to find it's changes so approving this PR as its functionality seems to work in newer versions of dconf-editor.
At some point I might need to try reverting all the UI changes from dconf-editor but keeping the backend updates in a local repo, but that might be unresolvable without applying commits by hand after all these years. Might be easier to just backport relocatable schema support to the older dconf, though so far I have been able to get by without it
|
I'm not opposing merge of this, but it needs another reviewer. I find the UI of GNOME's current dconf-editor nearly unusable
so I use a very old version that has the GNOME 2 UI but does not support relocatable schemas. Therefore, I could have
encountered another issue unique to me even when testing with the later version of dconf-editor.
|
|
these changes went into libmate-panel-applet-4.so |
|
I have the clock built in-process, so relaunching the panel relaunches the clock too
|
|
This will also detect old non usable forgotten settings in relocatable-schemas which can be removed. |
|
Is there another reviewer or should i merge it? |
support for dconf-editor relocatable schemas